Skip to content

XML documentation for LightGBM regression trainer. #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 2 commits into from
Apr 20, 2019
Merged

XML documentation for LightGBM regression trainer. #3410

codemzs merged 2 commits into from
Apr 20, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 18, 2019

towards #2522

@shmoradims shmoradims mentioned this pull request Apr 18, 2019
Closed
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #3410 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3410      +/-   ##
==========================================
- Coverage   72.69%   72.69%   -0.01%     
==========================================
  Files         807      807              
  Lines      145171   145171              
  Branches    16225    16225              
==========================================
- Hits       105536   105533       -3     
- Misses      35220    35223       +3     
  Partials     4415     4415
Flag Coverage Δ
#Debug 72.69% <ø> (-0.01%) ⬇️
#production 68.22% <ø> (-0.01%) ⬇️
#test 88.97% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...Microsoft.ML.LightGbm/LightGbmRegressionTrainer.cs 79.79% <ø> (ø) ⬆️
src/Microsoft.ML.LightGbm/LightGbmCatalog.cs 100% <ø> (ø) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.26% <0%> (-0.63%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️

@codecov
Copy link

codecov bot commented Apr 18, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a48dcef). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3410   +/-   ##
=========================================
  Coverage          ?   72.69%           
=========================================
  Files             ?      807           
  Lines             ?   145171           
  Branches          ?    16225           
=========================================
  Hits              ?   105533           
  Misses            ?    35223           
  Partials          ?     4415
Flag Coverage Δ
#Debug 72.69% <ø> (?)
#production 68.22% <ø> (?)
#test 88.97% <ø> (?)
Impacted Files Coverage Δ
...Microsoft.ML.LightGbm/LightGbmRegressionTrainer.cs 79.79% <ø> (ø)
src/Microsoft.ML.LightGbm/LightGbmCatalog.cs 100% <ø> (ø)

@codemzs codemzs force-pushed the lightgbmregressiondoc branch from d6624cd to 8916826 Compare April 20, 2019 00:10
shmoradims
shmoradims approved these changes Apr 20, 2019
View reviewed changes
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

singlis
singlis approved these changes Apr 20, 2019
View reviewed changes
Copy link
Member

@singlis singlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 8376a17 into dotnet:master Apr 20, 2019
@codemzs codemzs added the documentation Related to documentation of ML.NET label Apr 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yaeldekel yaeldekel Awaiting requested review from yaeldekel

3 more reviewers

@natke natke natke approved these changes

@shmoradims shmoradims shmoradims approved these changes

@singlis singlis singlis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codemzs @natke @shmoradims @singlis