Skip to content

XML documentation for Ordinary Least Squares trainer. #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 3 commits into from
Apr 20, 2019
Merged

XML documentation for Ordinary Least Squares trainer. #3405

codemzs merged 3 commits into from
Apr 20, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 18, 2019

towards #2522

@shmoradims shmoradims mentioned this pull request Apr 18, 2019
Closed
@codecov
Copy link

codecov bot commented Apr 18, 2019 •
edited
Loading

Codecov Report

Merging #3405 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3405      +/-   ##
==========================================
- Coverage   72.73%   72.73%   -0.01%     
==========================================
  Files         807      807              
  Lines      145206   145206              
  Branches    16230    16230              
==========================================
- Hits       105614   105613       -1     
+ Misses      35177    35176       -1     
- Partials     4415     4417       +2
Flag Coverage Δ
#Debug 72.73% <ø> (-0.01%) ⬇️
#production 68.27% <ø> (ø) ⬆️
#test 88.98% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
...icrosoft.ML.Mkl.Components/MklComponentsCatalog.cs 65.71% <ø> (ø) ⬆️
...Microsoft.ML.Mkl.Components/OlsLinearRegression.cs 66.3% <ø> (ø) ⬆️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.41%) ⬇️
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 73.73% <0%> (-0.33%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 60.05% <0%> (-0.27%) ⬇️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 100% <0%> (+20.51%) ⬆️

shmoradims
shmoradims reviewed Apr 18, 2019
View reviewed changes
shmoradims
shmoradims reviewed Apr 18, 2019
View reviewed changes
shmoradims
shmoradims reviewed Apr 18, 2019
View reviewed changes
shmoradims
shmoradims reviewed Apr 18, 2019
View reviewed changes
@shmoradims
Copy link

shmoradims commented Apr 18, 2019 •
edited by codemzs
Loading 

    /// </summary>

this change is missing. Options summary need to be updated too. #Resolved

Refers to: src/Microsoft.ML.Mkl.Components/OlsLinearRegression.cs:67 in 58e9889. [](commit_id = 58e9889, deletion_comment = False)

shmoradims
shmoradims reviewed Apr 20, 2019
View reviewed changes
shmoradims
shmoradims approved these changes Apr 20, 2019
View reviewed changes
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit b8bd51f into dotnet:master Apr 20, 2019
@codemzs codemzs added the documentation Related to documentation of ML.NET label Apr 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yaeldekel yaeldekel Awaiting requested review from yaeldekel

2 more reviewers

@natke natke natke approved these changes

@shmoradims shmoradims shmoradims approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codemzs @shmoradims @natke