Skip to content

XML documentation for Calibrated and Non Calibrated SDCA Binary Trainers. #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 4 commits into from
Apr 21, 2019
Merged

XML documentation for Calibrated and Non Calibrated SDCA Binary Trainers. #3395

codemzs merged 4 commits into from
Apr 21, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 18, 2019

towards #2522

@codemzs codemzs requested review from shmoradims and yaeldekel April 18, 2019 06:51
@shmoradims shmoradims mentioned this pull request Apr 18, 2019
Closed
@codemzs codemzs requested a review from natke April 18, 2019 06:53
@codecov
Copy link

codecov bot commented Apr 18, 2019 •
edited
Loading

Codecov Report

Merging #3395 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3395      +/-   ##
==========================================
- Coverage   72.76%   72.69%   -0.07%     
==========================================
  Files         808      807       -1     
  Lines      145452   145172     -280     
  Branches    16244    16225      -19     
==========================================
- Hits       105842   105540     -302     
- Misses      35189    35218      +29     
+ Partials     4421     4414       -7
Flag Coverage Δ
#Debug 72.69% <ø> (-0.07%) ⬇️
#production 68.23% <ø> (-0.05%) ⬇️
#test 88.97% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
...oft.ML.StandardTrainers/StandardTrainersCatalog.cs 92.34% <ø> (ø) ⬆️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 72.95% <ø> (ø) ⬆️
.../MulticlassClassification/MetaMulticlassTrainer.cs 85.86% <0%> (-6%) ⬇️
.../Microsoft.ML.Data/Prediction/CalibratorCatalog.cs 90.71% <0%> (-4%) ⬇️
src/Microsoft.ML.Data/Prediction/Calibrator.cs 72.84% <0%> (-3.09%) ⬇️
...s/Api/CookbookSamples/CookbookSamplesDynamicApi.cs 93.49% <0%> (-2%) ⬇️
.../Evaluators/Metrics/BinaryClassificationMetrics.cs 95% <0%> (-0.24%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.21%) ⬇️
test/Microsoft.ML.Functional.Tests/Common.cs 98.23% <0%> (-0.16%) ⬇️
src/Microsoft.ML.Data/Transforms/Hashing.cs 92.18% <0%> (-0.15%) ⬇️
... and 86 more

wschin
wschin reviewed Apr 18, 2019
View reviewed changes
wschin
wschin reviewed Apr 18, 2019
View reviewed changes
wschin
wschin reviewed Apr 18, 2019
View reviewed changes
wschin
wschin reviewed Apr 18, 2019
View reviewed changes
@codemzs
Copy link
Member Author

codemzs commented Apr 18, 2019 •
edited
Loading

Thanks @wschin, the text was taken from existing documentation but I’ll update it with your feedback! #Resolved

@codemzs codemzs changed the title XML documentation for Calibrated and Non Calibrated SDCA Trainers. XML documentation for Calibrated and Non Calibrated SDCA Binary Trainers. Apr 18, 2019
natke
natke reviewed Apr 21, 2019
View reviewed changes
@codemzs codemzs requested a review from natke April 21, 2019 19:29
shmoradims
shmoradims reviewed Apr 21, 2019
View reviewed changes
shmoradims
shmoradims approved these changes Apr 21, 2019
View reviewed changes
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 3d6f66d into dotnet:master Apr 21, 2019
@codemzs codemzs added the documentation Related to documentation of ML.NET label Apr 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yaeldekel yaeldekel Awaiting requested review from yaeldekel

4 more reviewers

@wschin wschin wschin left review comments

@singlis singlis singlis left review comments

@natke natke natke approved these changes

@shmoradims shmoradims shmoradims approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codemzs @natke @wschin @shmoradims @singlis