Skip to content

Conversation

@TomFinley
Copy link
Contributor

Towards #3095.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this doc work @TomFinley. It will definitely reap many rewards in the future.

Copy link
Contributor

@shauheen shauheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #3288 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3288      +/-   ##
==========================================
+ Coverage   72.63%   72.65%   +0.01%     
==========================================
  Files         807      807              
  Lines      145129   145129              
  Branches    16220    16220              
==========================================
+ Hits       105417   105437      +20     
+ Misses      35295    35272      -23     
- Partials     4417     4420       +3
Flag Coverage Δ
#Debug 72.65% <ø> (+0.01%) ⬆️
#production 68.19% <ø> (+0.01%) ⬆️
#test 88.94% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Core/Data/IEstimator.cs 84.53% <ø> (ø) ⬆️
src/Microsoft.ML.DataView/VectorType.cs 89.41% <ø> (ø) ⬆️
src/Microsoft.ML.DataView/DataViewType.cs 86.82% <ø> (ø) ⬆️
...StandardTrainers/Standard/LinearModelParameters.cs 60.31% <0%> (+0.26%) ⬆️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 77.94% <0%> (+6.98%) ⬆️

@TomFinley TomFinley merged commit 9c03a1c into dotnet:master Apr 11, 2019
@TomFinley TomFinley deleted the DocDataView branch April 11, 2019 17:53
TomFinley added a commit to TomFinley/machinelearning that referenced this pull request Apr 12, 2019
* Update IDataView principles, type system documentation.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants