Added samples for Poisson and OGD regression #3067
Conversation
| var metrics = mlContext.Regression.Evaluate(transformedTestData); | ||
| SamplesUtils.ConsoleUtils.PrintMetrics(metrics); | ||
|
|
||
|
|
| Console.WriteLine($"Label: {p.Label:F3}, Prediction: {p.Score:F3}"); | ||
|
|
||
| // Expected output: | ||
| // OGD doesn't work: https://github.com/dotnet/machinelearning/issues/2425 |
There was a problem hiding this comment.
Let's not have a sample if we can't show it working. I'd say remove OGD and add that we need a sample to the open issue.
There was a problem hiding this comment.
Also, the issue says that it doesn't have baselines, not that it doesn't work. Can you update the issue?
In reply to: 268338288 [](ancestors = 268338288)
There was a problem hiding this comment.
OGD works, there are 5 tests about it running regularly.
In reply to: 268338288 [](ancestors = 268338288)
There was a problem hiding this comment.
How about we put the output in and add a // TODO #ISSUE_NUMBER: Explanation above the output.
In reply to: 268347907 [](ancestors = 268347907,268338288)
Codecov Report
@@ Coverage Diff @@
## master #3067 +/- ##
==========================================
+ Coverage 72.53% 72.53% +<.01%
==========================================
Files 805 805
Lines 144243 144243
Branches 16175 16175
==========================================
+ Hits 104620 104625 +5
+ Misses 35222 35219 -3
+ Partials 4401 4399 -2
|
ghost
locked as resolved and limited conversation to collaborators
3 participants
Related to #2522