Fixing the project reference in the nuget packages for OnnxTransformer #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found while fixing dotnet#689, moved to separate commit.
singlis
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2705 +/- ##
=========================================
Coverage ? 71.58%
=========================================
Files ? 805
Lines ? 142004
Branches ? 16119
=========================================
Hits ? 101651
Misses ? 35916
Partials ? 4437
|
Ivanidzo4ka
approved these changes
Feb 23, 2019
Contributor
Ivanidzo4ka
left a comment
Ivanidzo4ka
left a comment
There was a problem hiding this comment.
Thank you for taking care of that!
eerhardt
approved these changes
Feb 23, 2019
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Good find. It’s unfortunate that this doesn’t cause an error....
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while fixing Consider removing Sweeper, PipelineInference, and ResultProcessor assemblies from Microsoft.ML nuget #689, moved to separate commit.