Skip to content

Microsoft.ML.Internal.Internallearn namespace requires certain internalization. #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 3 commits into from
Feb 20, 2019
Merged

Microsoft.ML.Internal.Internallearn namespace requires certain internalization. #2667

codemzs merged 3 commits into from
Feb 20, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Feb 20, 2019

fixes #2590

@TomFinley
Copy link
Contributor

TomFinley commented Feb 20, 2019 •
edited
Loading 

public sealed class ReverseComparer<T> : IComparer<T>

How about this guy? (Can we even nest him further? This seems a bit weird.)

Refers to: src/Microsoft.ML.Data/Dirty/PredictionUtils.cs:160 in 1fe6806. [](commit_id = 1fe6806, deletion_comment = False)

@TomFinley
Copy link
Contributor

TomFinley commented Feb 20, 2019 

public sealed class ReverseComparer<T> : IComparer<T>

I also like the directory name Dirty here. :D

In reply to: 465734701 [](ancestors = 465734701)

Refers to: src/Microsoft.ML.Data/Dirty/PredictionUtils.cs:160 in 1fe6806. [](commit_id = 1fe6806, deletion_comment = False)

@codecov
Copy link

codecov bot commented Feb 20, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a25763e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2667   +/-   ##
=========================================
  Coverage          ?   71.57%           
=========================================
  Files             ?      800           
  Lines             ?   141789           
  Branches          ?    16107           
=========================================
  Hits              ?   101486           
  Misses            ?    35854           
  Partials          ?     4449
Flag Coverage Δ
#Debug 71.57% <ø> (?)
#production 67.87% <ø> (?)
#test 85.73% <ø> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.Data/Dirty/PredictorInterfaces.cs 0% <ø> (ø)
src/Microsoft.ML.Data/Utilities/SlotDropper.cs 99.24% <ø> (ø)
src/Microsoft.ML.Data/Dirty/PredictionUtils.cs 28.91% <ø> (ø)
...icrosoft.ML.Data/Training/EarlyStoppingCriteria.cs 83.2% <ø> (ø)

@codemzs codemzs self-assigned this Feb 20, 2019
@codemzs codemzs added the API Issues pertaining the friendly API label Feb 20, 2019
@codemzs codemzs added this to the 0219 milestone Feb 20, 2019
TomFinley
TomFinley approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @codemzs !

yaeldekel
yaeldekel reviewed Feb 20, 2019
View reviewed changes
src/Microsoft.ML.Data/Dirty/PredictorInterfaces.cs Outdated
/// Signature for loading from a file name.
/// </summary>
public delegate void SignaturePredictorFromFile(string fileName);
internal delegate void SignaturePredictorFromFile(string fileName);
Copy link

@yaeldekel yaeldekel Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SignaturePredictorFromFile [](start = 27, length = 26)

Is this used anywhere?

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Feb 20, 2019 

public delegate void SignatureFeatureScorerTrainer();

touch me

Refers to: src/Microsoft.ML.Data/Dirty/PredictorInterfaces.cs:149 in a7a3170. [](commit_id = a7a3170, deletion_comment = False)

yaeldekel
yaeldekel approved these changes Feb 20, 2019
View reviewed changes
Copy link

@yaeldekel yaeldekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 96ec842 into dotnet:master Feb 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Ivanidzo4ka Ivanidzo4ka Awaiting requested review from Ivanidzo4ka

2 more reviewers

@TomFinley TomFinley TomFinley approved these changes

@yaeldekel yaeldekel yaeldekel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@codemzs codemzs

Labels

API Issues pertaining the friendly API

Projects

None yet

Milestone

0219

Development

Successfully merging this pull request may close these issues.

Microsoft.ML.Internal.Internallearn namespace requires certain internalization

4 participants

@codemzs @TomFinley @Ivanidzo4ka @yaeldekel