Remove value tuples from public TransformCatalog APIs #2641
Conversation
|
|
||
| namespace Microsoft.ML | ||
| { | ||
| public sealed class SimpleColumnInfo |
There was a problem hiding this comment.
SimpleColumnInfo [](start = 24, length = 16)
I think @rogancarr has issue where he don't like ColumnInfo name. #2554
I wonder how much he would hate this one.
SimpleMapping,SimplePair?
There was a problem hiding this comment.
No strong opinion, I just think that we should have a conversation about naming these things :)
In reply to: 258285683 [](ancestors = 258285683)
There was a problem hiding this comment.
How about ColumnNamePair or something similar? I think something containing 'mapping' or 'pair' would be too general, wouldn't it?
Or I could leave it as SimpleColumnInfo and add a comment about it in the issue so we can change it when we find a good name for ColumnInfo?
In reply to: 258297894 [](ancestors = 258297894,258285683)
There was a problem hiding this comment.
I added mention of this column to #2554.
Let's merge this one, and figure out proper naming in that issue.
ghost
locked as resolved and limited conversation to collaborators
5 participants
Fixes #2581 .