Skip to content

Internalization of OneToOne and ManyToOne Column classes #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 2 commits into from
Feb 20, 2019
Merged

Internalization of OneToOne and ManyToOne Column classes #2632

codemzs merged 2 commits into from
Feb 20, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Feb 19, 2019

fixes #2631

@codemzs codemzs self-assigned this Feb 19, 2019
@codemzs codemzs added the API Issues pertaining the friendly API label Feb 19, 2019
@codemzs codemzs added this to the 0219 milestone Feb 19, 2019
@codecov
Copy link

codecov bot commented Feb 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a25763e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2632   +/-   ##
=========================================
  Coverage          ?   71.53%           
=========================================
  Files             ?      800           
  Lines             ?   141847           
  Branches          ?    16119           
=========================================
  Hits              ?   101475           
  Misses            ?    35922           
  Partials          ?     4450
Flag Coverage Δ
#Debug 71.53% <ø> (?)
#production 67.82% <ø> (?)
#test 85.73% <ø> (?)
Impacted Files Coverage Δ
...Microsoft.ML.Data/Transforms/ColumnBindingsBase.cs 72.53% <ø> (ø)
...L.Transforms/Text/WordHashBagProducingTransform.cs 51.7% <ø> (ø)

yaeldekel
yaeldekel reviewed Feb 20, 2019
View reviewed changes
Ivanidzo4ka
Ivanidzo4ka approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

yaeldekel
yaeldekel approved these changes Feb 20, 2019
View reviewed changes
Copy link

@yaeldekel yaeldekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 30df61a into dotnet:master Feb 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TomFinley TomFinley Awaiting requested review from TomFinley

@zeahmed zeahmed Awaiting requested review from zeahmed

2 more reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@yaeldekel yaeldekel yaeldekel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@codemzs codemzs

Labels

API Issues pertaining the friendly API

Projects

None yet

Milestone

0219

Development

Successfully merging this pull request may close these issues.

Internalization of OneToOne and ManyToOne Column classes

3 participants

@codemzs @Ivanidzo4ka @yaeldekel