Repository navigation
Adding a new ubuntu CI leg - #2516
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2516 +/- ##
=========================================
Coverage ? 71.53%
=========================================
Files ? 801
Lines ? 141876
Branches ? 16122
=========================================
Hits ? 101493
Misses ? 35928
Partials ? 4455
|
Anipik
changed the title
| buildScript: ./build.sh | ||
| customMatrixes: | ||
| Build_Debug_Intrinsics: | ||
| _configuration: Debug-Intrinsics |
There was a problem hiding this comment.
I thought we were going to switch to the Release to use 3.0/Intrinsics. That way we get Debug and Release coverage across both versions:
CentOS|Debug|3.0
CentOS|Release|2.1
Ubuntu|Debug|2.1
Ubuntu|Release|3.0
There was a problem hiding this comment.
sorry I didn't saw it correctly, I will correct it
There was a problem hiding this comment.
Moving back the CI to netcoreap2.1 untill the cli people resolves the https://github.com/dotnet/cli/issues/10802
|
@eerhardt @jignparm can you please review this one. I have addressed the feedback. @eerhardt currently i moved back the ubuntu ci to the netcoreapp2.1. |
|
Hi @Anipik thank you for working on this. Can't we narrow it down a little, to specific components of interest? As far as I understood there were only a few things that would be potentially problematic. It's just a little irritating to think of this 99% C# codebase getting yet another fully realized leg just to run what is really only one test of interest. |
| { | ||
| internal static bool CheckLibcVersionGreaterThanMinimum(double minVersion) | ||
| { | ||
| #if !NETFRAMEWORK |
There was a problem hiding this comment.
Why the #if here? The if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) will catch anytime we are running on Windows, and return false.
There was a problem hiding this comment.
The reason behind this is Marshal.PtrToStringUTF8 api is not available for netframework which leads to compile error
@TomFinley - See #2381 for the reasoning. |
ghost
locked as resolved and limited conversation to collaborators
Related To #2381
Currently we are just running the tests on centos linux. A couple of libraries dont run on centos distro but run on ubuntu so we are adding a new ci leg to increase coverafe and run these tests on ubuntu