-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Meta Issue] Changing defaults #4749
Copy link
Copy link
Closed
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly APIP1Priority of the issue for triage purpose: Needs to be fixed soon.Priority of the issue for triage purpose: Needs to be fixed soon.lightgbmBugs related lightgbmBugs related lightgbmrankingBugs related ranking tasksBugs related ranking tasks
Metadata
Metadata
Assignees
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly APIP1Priority of the issue for triage purpose: Needs to be fixed soon.Priority of the issue for triage purpose: Needs to be fixed soon.lightgbmBugs related lightgbmBugs related lightgbmrankingBugs related ranking tasksBugs related ranking tasks
Type
Fields
Give feedbackNo fields configured for issues without a type.
First of all, is this a breaking change? @terrajobst suggested it is an acceptable breaking change #2305 (comment), @eerhardt commented that is was decided that changing defaults is acceptable #2305 (comment)
Change the following defaults based on results from @justinormont:
Update default n-gram length for Text Transform to match default text recipe #2870
FeatirizeTextdefault n-grams lengths to match default text recipe:Change default # of iterations in Averaged Perceptron to 10 #2305
AveragedPerceptrondefault iterations from 1 to 10RowGroupColumnName of ranking trainers options class defaults to null #3365
RowGroupColumnNameinFastTreeandLightGbmranking trainerOptionsclasses:null->'GroupId'Optionsclass, where the default is'GroupId'nulleverywhere or'GroupId'everywhere.cc: @harishsk @justinormont @gvashishtha @eerhardt