-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
up-for-grabsA good issue to fix if you are trying to contribute to the projectA good issue to fix if you are trying to contribute to the project
Milestone
Description
Currently FastTree uses a 16byte MD5 hash to ensure uniqueness of content.
There are several issues with this:
- The MD5 hash is a (weak) cryptographic hash, resulting in additional work for the release process with regards to export controls.
- MD5 hash is quite slow and memory intensive
Suggested Fix:
- Rename MD5Hash to ContentHash or similar.
- Same goes to MD5Hasher
- Update all Hash(,,,) methods to not use MD5CryptoServiceProvider but murmur hash or equivalent instead.
- Ensure no reference to System.Security.Cryptography namespace exists in the codebase afterwards.
- Alternatively, we can extend the murmurhash class to return
Metadata
Metadata
Assignees
Labels
up-for-grabsA good issue to fix if you are trying to contribute to the projectA good issue to fix if you are trying to contribute to the project