-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
For some of the learners e.g. SdcaRegression ML.NET public API exposes parameter weights
machinelearning/src/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Lines 65 to 70 in cabf55b
| public static SdcaRegressionTrainer StochasticDualCoordinateAscent(this RegressionContext.RegressionTrainers ctx, | |
| string labelColumn = DefaultColumnNames.Label, | |
| string featureColumn = DefaultColumnNames.Features, | |
| string weights = null, | |
| ISupportSdcaRegressionLoss loss = null, | |
| float? l2Const = null, |
However, the advanced Options for SdcaRegressionTrainer do not have a field for 'WeightColumn'. Also, I believe the algo itself does not use weights (need to verify)
We need to scrub our public API for such spurious uses of weights parameter.
EDIT :
- Based on investigations (see below), we see that the
SdcaRegressionTrainerdoes use the weights column. So the proper fix would be to ensure that the weight column passed in the constructor gets used by the trainer. - For the example above, we need to add
WeightColumnin the advancedOptionsforSdcaRegressionTrainerand verify it gets used by the SDCA trainer.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working