Skip to content

Commit bde8e6c

Browse files
Vladimir AubrechtCopilot
authored andcommitted
Ship SymSgdNative in win-arm64 and linux-arm64 NuGet packages
The packaging exclusion kept SymSgdNative out of all arm NuGet packages, so even though this PR builds and tests it on Windows/Linux arm64, consumers wouldn't get it. Include it for arm64/arm except on macOS, where SymSgdNative isn't built (the macOS cross-compilation runner has no arm64 libomp). Replaces the stale TODO. Co-authored-by: Copilot <[email protected]>
1 parent 42b5728 commit bde8e6c

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎src/Native/Native.proj‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,10 @@
189189
RelativePath="Microsoft.ML.CpuMath\runtimes\$(PackageRid)\nativeassets\net8.0" />
190190
<NativePackageAsset Include="$(NativeAssetsBuiltPath)\$(NativeLibPrefix)LdaNative$(NativeLibExtension)"
191191
RelativePath="Microsoft.ML\runtimes\$(PackageRid)\native" />
192-
<!-- TODO: once we fix the 4 intel MKL methods, SymSgdNative will need to go back in. -->
193-
<NativePackageAsset Condition="'$(TargetArchitecture)' != 'arm64' And '$(TargetArchitecture)' != 'arm'"
192+
<!-- SymSgdNative is built on x64 and on Windows/Linux arm64 (with its self-contained CBLAS
193+
shim). It is not built on macOS arm64 (the macOS cross-compilation runner has no arm64
194+
libomp), so only exclude it there. -->
195+
<NativePackageAsset Condition="!($([MSBuild]::IsOSPlatform('osx')) And ('$(TargetArchitecture)' == 'arm64' Or '$(TargetArchitecture)' == 'arm'))"
194196
Include="$(NativeAssetsBuiltPath)\$(NativeLibPrefix)SymSgdNative$(NativeLibExtension)"
195197
RelativePath="Microsoft.ML.Mkl.Components\runtimes\$(PackageRid)\native" />
196198
<NativePackageAsset Condition="'$(TargetArchitecture)' != 'arm64' And '$(TargetArchitecture)' != 'arm'"

0 commit comments

Comments
 (0)