updates based on PR comments

michaelgsharp · michaelgsharp · commit 701d9d85204a · 2020-06-04T16:56:27.000-07:00
diff --git a/src/Microsoft.ML.Transforms/MissingValueReplacingUtils.cs b/src/Microsoft.ML.Transforms/MissingValueReplacingUtils.cs
@@ -389,9 +389,8 @@ public void Update(TType val)
                 if (!_validityCheck(val))
                     return;
 
-                int count = 1;
-                if (_valueCounts.TryGetValue(val, out int curCount))
-                    count = curCount + 1;
+                if (_valueCounts.TryGetValue(val, out int count))
+                    count++;
 
                 _valueCounts[val] = count;
 
diff --git a/test/Microsoft.ML.Tests/Transformers/NAReplaceTests.cs b/test/Microsoft.ML.Tests/Transformers/NAReplaceTests.cs
@@ -125,7 +125,7 @@ public void NAReplace()
                 new TextLoader.Column("ScalarFloat", DataKind.Single, 1),
                 new TextLoader.Column("ScalarDouble", DataKind.Double, 1),
                 new TextLoader.Column("VectorFloat", DataKind.Single, 1, 4),
-                new TextLoader.Column("VectorDoulbe", DataKind.Double, 1, 4)
+                new TextLoader.Column("VectorDouble", DataKind.Double, 1, 4)
             });
 
             var wrongCollection = new[] { new TestClass() { A = 1, B = 3, C = new float[2] { 1, 2 }, D = new double[2] { 3, 4 } } };
@@ -134,8 +134,8 @@ public void NAReplace()
             var est = ML.Transforms.ReplaceMissingValues("A", "ScalarFloat", replacementMode: MissingValueReplacingEstimator.ReplacementMode.Maximum)
                 .Append(ML.Transforms.ReplaceMissingValues("B", "ScalarDouble", replacementMode: MissingValueReplacingEstimator.ReplacementMode.Mean))
                 .Append(ML.Transforms.ReplaceMissingValues("C", "VectorFloat", replacementMode: MissingValueReplacingEstimator.ReplacementMode.Mean))
-                .Append(ML.Transforms.ReplaceMissingValues("D", "VectorDoulbe", replacementMode: MissingValueReplacingEstimator.ReplacementMode.Minimum))
-                .Append(ML.Transforms.ReplaceMissingValues("E", "VectorDoulbe", replacementMode: MissingValueReplacingEstimator.ReplacementMode.Mode));
+                .Append(ML.Transforms.ReplaceMissingValues("D", "VectorDouble", replacementMode: MissingValueReplacingEstimator.ReplacementMode.Minimum))
+                .Append(ML.Transforms.ReplaceMissingValues("E", "VectorDouble", replacementMode: MissingValueReplacingEstimator.ReplacementMode.Mode));
 
             TestEstimatorCore(est, data, invalidInput: invalidData);
             var outputPath = GetOutputPath("NAReplace", "featurized.tsv");
