Disable function specialization #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It breaks mono's AOT compiled code, because the specialized functions are outside of generated EH frame code range. We can re-enable it, once we fix EH frame generation in mono.
akoeplinger
approved these changes
Jul 20, 2024
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
Thanks! please open a runtime issue to track reenabling this
Member
|
@radekdoulik @steveisok should we do this on the llvm-16.x branch too - it might be related to the plt_entry asserts on android |
Member
Yes, I think that would be wise. The customer having issues on android has given us access to their repo. We should backport and try to see if that solves the problem. |
Member
Author
|
I updated the runtime bump PR, so we should have another CI round in few hours. Hopefully it will look fine and I will open PR for 16.x as well. |
Member
Author
|
/backport to dotnet/main-16.x |
Member
Author
|
ah, that would only work on runtime :-) |
radekdoulik
added a commit
to radekdoulik/llvm-project
that referenced
this pull request
Jul 21, 2024
It breaks mono's AOT compiled code, because the specialized functions are outside of generated EH frame code range. We can re-enable it, once we fix EH frame generation for mono.
steveisok
added a commit
that referenced
this pull request
Jul 21, 2024
Backport of Disable function specialization (#599)
radekdoulik
added a commit
that referenced
this pull request
Aug 16, 2024
It breaks mono's AOT compiled code, because the specialized functions are outside of generated EH frame code range. We can re-enable it, once we fix EH frame generation for mono.
radekdoulik
added a commit
that referenced
this pull request
Sep 2, 2024
It breaks mono's AOT compiled code, because the specialized functions are outside of generated EH frame code range. We can re-enable it, once we fix EH frame generation for mono.
radekdoulik
added a commit
that referenced
this pull request
Sep 12, 2024
It breaks mono's AOT compiled code, because the specialized functions are outside of generated EH frame code range. We can re-enable it, once we fix EH frame generation for mono.
radekdoulik
added a commit
that referenced
this pull request
Sep 19, 2024
It breaks mono's AOT compiled code, because the specialized functions are outside of generated EH frame code range. We can re-enable it, once we fix EH frame generation for mono.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It breaks mono's AOT compiled code, because the specialized functions are outside of generated EH frame code range.
We can re-enable it, once we fix EH frame generation for mono.