Remove LLVM_TOOLS_TO_BUILD option from llvm.proj #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a custom change added in da3d772 but we missed porting that to recent branches. Given we've not even noticed until now and it just causes building a bit more tools I'd argue it's better to just remove this.
BrzVlad
approved these changes
Jul 9, 2024
akoeplinger
added a commit
that referenced
this pull request
Jul 17, 2024
This was a custom change added in da3d772 but we missed porting that to recent branches. Given we've not even noticed until now and it just causes building a bit more tools I'd argue it's better to just remove this.
radekdoulik
pushed a commit
that referenced
this pull request
Aug 16, 2024
This was a custom change added in da3d772 but we missed porting that to recent branches. Given we've not even noticed until now and it just causes building a bit more tools I'd argue it's better to just remove this.
radekdoulik
pushed a commit
that referenced
this pull request
Sep 2, 2024
This was a custom change added in da3d772 but we missed porting that to recent branches. Given we've not even noticed until now and it just causes building a bit more tools I'd argue it's better to just remove this.
radekdoulik
pushed a commit
that referenced
this pull request
Sep 12, 2024
This was a custom change added in da3d772 but we missed porting that to recent branches. Given we've not even noticed until now and it just causes building a bit more tools I'd argue it's better to just remove this.
radekdoulik
pushed a commit
that referenced
this pull request
Sep 19, 2024
This was a custom change added in da3d772 but we missed porting that to recent branches. Given we've not even noticed until now and it just causes building a bit more tools I'd argue it's better to just remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a custom change added in da3d772 but we missed porting that to recent branches.
Given we've not even noticed until now and it just causes building a bit more tools I'd argue it's better to just remove this.