Skip to content

Dynamically link ucrt to objwriter.dll #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalStrehovsky merged 2 commits into from
Mar 17, 2023
Merged

Dynamically link ucrt to objwriter.dll #386

MichalStrehovsky merged 2 commits into from
Mar 17, 2023

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Mar 16, 2023

Re-apply #316 that was apparently lost in the transition to main.

Cc @dotnet/ilc-contrib @markples

@MichalStrehovsky
Dynamically link ucrt to objwriter.dll
9d4a557 
Re-apply #316 that was apparently lost in the transition to main.
@MichalStrehovsky MichalStrehovsky enabled auto-merge (squash) March 16, 2023 08:08
@jkotas
Copy link
Member

jkotas commented Mar 16, 2023

The build break is caused by hardcoded Release build type here https://github.com/dotnet/llvm-project/blob/dotnet/main/llvm.proj#L66 . We may need to also check LLVM_USE_CRT_RELEASE to validate that it is ok to link ucrt dynamically https://github.com/dotnet/llvm-project/blob/dotnet/main/llvm.proj#L85 .

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Mar 17, 2023

The build break is caused by hardcoded Release build type here https://github.com/dotnet/llvm-project/blob/dotnet/main/llvm.proj#L66 . We may need to also check LLVM_USE_CRT_RELEASE to validate that it is ok to link ucrt dynamically https://github.com/dotnet/llvm-project/blob/dotnet/main/llvm.proj#L85 .

Thanks! Wow, that's confusing.

@MichalStrehovsky MichalStrehovsky merged commit f44dee2 into dotnet/main Mar 17, 2023
@akoeplinger akoeplinger deleted the MichalStrehovsky-patch-1 branch March 29, 2023 13:43
@akoeplinger akoeplinger mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@markples markples markples approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichalStrehovsky @jkotas @markples