Dynamically link ucrt to objwriter.dll #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how we link CRT in the runtime repo:
jkotas
approved these changes
Nov 18, 2022
MichalStrehovsky
added a commit
that referenced
this pull request
Mar 16, 2023
Re-apply #316 that was apparently lost in the transition to main.
MichalStrehovsky
added a commit
that referenced
this pull request
Mar 17, 2023
Re-apply #316 that was apparently lost in the transition to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes objwriter.dll about 200 kB smaller.
This is how we link CRT in the runtime repo:
https://github.com/dotnet/runtime/blob/b2cf1c7a3796d5fb5acb0237017d8a61c6d3dc6b/eng/native/configurecompiler.cmake#L104-L106
Cc @BrianBohe @markples @dotnet/ilc-contrib