Allow some Globalization code to be dynamically removed.#596
Merged
marek-safar merged 1 commit intodotnet:masterfrom Jun 6, 2019
Merged
Allow some Globalization code to be dynamically removed.#596marek-safar merged 1 commit intodotnet:masterfrom
marek-safar merged 1 commit intodotnet:masterfrom
Conversation
baulig
commented
May 30, 2019
| if (FeatureGlobalization) | ||
| ExcludeGlobalization (type); | ||
|
|
||
| if (RemoveCustomAttributes (type)) { |
Author
There was a problem hiding this comment.
This block has already been merged, ignore.
baulig
commented
May 30, 2019
| public bool FeatureCOM { get; set; } | ||
| public bool FeatureETW { get; set; } | ||
| public bool FeatureSRE { get; set; } | ||
|
|
Author
There was a problem hiding this comment.
This block has already been merged, ignore.
baulig
commented
May 30, 2019
| FeatureCOM = excluded_features.Contains ("com"), | ||
| FeatureETW = excluded_features.Contains ("etw"), | ||
| FeatureSRE = excluded_features.Contains ("sre"), | ||
| FeatureGlobalization = excluded_features.Contains ("globalization") |
Author
There was a problem hiding this comment.
This block has already been merged, ignore.
Author
|
Please disregard the SRE changes; I intentionally made this draft against an older version of the linker as I'm having some difficulties with the SDK-style projects in VSMac. I got them to build, but Intellisense is completely messed up, thus making it very hard to edit / debug. |
Author
|
All sizes are from the wasm profile.
|
Author
|
Trying to analyzing the difference between the linker and my tool ...
still investigating .... |
Author
|
With my tool, but without touching Now when looking at individual classes / method - but tool does not account for metadata size, so these numbers are a bit off on the lower side. The entire However, I can also do a diff between individual classes.
Okay, I think that gave me a few methods to look at and apply the same technique. |
Author
|
Disregard this (generated output from my tool), it's just for my own reference later on. |
Author
|
Disregard as well; generated output. |
Author
|
Okay, looking at However, we can try to split that method into two parts then use the trick showed in this draft to remove one of them - this should have about the same effect. And we can probably apply the same technique to some other functions as well. But even without that, we still have |
Contributor
@baulig Out of curiosity, what tool are you referring to? |
Author
|
Latest commit brought us to 680448 versus 675328, slowly getting better ... |
Author
It's a research project that I've been working on recently. I created a tool called "Linker Optimizer" that does basic block scanning and dead code elimination. |
Contributor
|
Neat. We have things like that in our UnityLinker. I've mentioned it to @marek-safar a couple times in passing over the past year or so. The conclusion at the time has always been that it was best to keep the logic in our linker so that we could iterate faster. Maybe the time is near to bring our efforts upstream and combine forces? Or do you have a completely different approach you are looking to take (i.e. not inside monolinker)? |
Author
|
I would absolutely love to collaborate more on these issues instead of us duplicating work. The reason why I put my tool into a separate module was simply because I needed something fast to use during my day-to-day work and it was easier and faster for me to have it in a place where I can easily modify it at any time without worrying about breaking or blocking somebody else's work. However, long-term we should look into incorporating that into the linker in some way. |
Author
|
BCL PR's are now up: mono/corefx#298 and mono/mono#14825. We need to bump CoreFX after landing that one. |
baulig
force-pushed
the
work-globalization-gate
branch
2 times, most recently
from
f0978e6 to
0c3112a
Compare
This requires mono/corefx#298 and mono/mono#14825. We are using the same techinique as previously employed in dotnet#590 to dynamically remove the `System.Reflection.Emit` code. Since the linker does not currently support dead code elimination, it cannot break down any conditionals inside method bodies. One trick that we use to work around this is to move those conditional pieces into separate methods; then we can give the linker a list of those methods and tell it to replace their bodies with exceptions. After this has been done in the BCL, we need to explicitly tell the linker to turn those method bodies into stubs when `--exclude-feature globalization`. Ideally, we would want to use `MethodAction.ConvertToStub` instead of `ConvertToThrow` here, but we'd have to extend the code rewriter first to support methods with arbitrary return types and parameters.
baulig
force-pushed
the
work-globalization-gate
branch
from
0c3112a to
7f18668
Compare
baulig
changed the title
Contributor
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: allow dynamic removal (as it without rebuilding corlib) of some of the globalization code when
--exclude-feature globalizationis provided.Currently removes the Japanese, Taiwan and Hebrew calendars as well as Hebrew numbers.
This requires mono/corefx#298 and mono/mono#14825.
We are using the same techinique as previously employed in #590 to dynamically remove the
System.Reflection.Emitcode.Since the linker does not currently support dead code elimination, it cannot break down any conditionals inside method bodies. One trick that we use to work around this is to move those conditional pieces into separate methods; then we can give the linker a list of those methods and tell it to replace their bodies with exceptions.
After this has been done in the BCL, we need to explicitly tell the linker to turn those method bodies into stubs when
--exclude-feature globalization.Ideally, we would want to use
MethodAction.ConvertToStubinstead ofConvertToThrowhere, but we'd have to extend the code rewriter first to support methods with arbitrary return types and parameters.