Port dotnet/runtime#82197 to dotnet/linker #3203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: dotnet/runtime#82197
Customer Impact:
Addresses the issue in dotnet/runtime#81746. The linker can produce invalid IL when a user assembly is not trimmed, but the framework is trimmed (as is common in wasm and blazor). If a user code implements a static abstract interface method but the interface method is never used, the trimmer removes the interface method from the interface, but leaves the (now dangling) reference to it in the overriding method.
This fixes the issue by making sure all methods referenced in the .overrides metadata of method X are marked if method X is in a 'copy' assembly (an untrimmed assembly), where previously we would postpone marking the .overrides if the base was static abstract.
Testing:
The existing tests in the repo guard against any regressions, and a new test case demonstrates the change in behavior.
Risk:
There is very little risk. The change in behavior is very small, and the situations there is a change in behavior seem to be uncommon.