Remove redundant checks in IntrinsicId switch statements #3060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
approved these changes
Oct 7, 2022
| Debug.Assert (requiresDataFlowAnalysis || annotatedMethodReturnValue.DynamicallyAccessedMemberTypes == DynamicallyAccessedMemberTypes.None); | ||
|
|
||
| intrinsicId = Intrinsics.GetIntrinsicIdForMethod (calledMethod); | ||
| intrinsicId = knownIntrinsicId ?? Intrinsics.GetIntrinsicIdForMethod (calledMethod); |
Member
There was a problem hiding this comment.
I would prefer we make the parameter mandatory. In linker it should be always known, in analyzer it isn't, but it's easy to call the helper.
| && calledMethod.HasParameterOfType (0, "System.Reflection.BindingFlags") | ||
| && !calledMethod.IsStatic (): { | ||
|
|
||
| case IntrinsicId.Type_GetConstructors: |
Member
There was a problem hiding this comment.
Since you're in this area - could you please rename these enums to be more descriptive? For example GetMethods has two overloads, with and without parameters. This one is the one with the parameter, but the enum doesn't make that obvious in any way. So maybe GetMethod_BindingFlags or something like that.
There's a related work item #1623 which is about making the matches more specific and robust. Maybe not in this change, but it would be a really nice thing to cleanup.
Rename GetMembers(BindingFlags) enum variants Make intrinsicId a required param Add doc comments for a few intrinsicIds
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…er#3060) Remove redundant checks on intrinsicIds Rename Get<Member>s(BindingFlags) enum variants Make intrinsicId a required param Add doc comments for a few intrinsicIds Commit migrated from dotnet/linker@6000a84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ReflectionMethodBodyScanner and HandleCallAction, we do many of the same checks that already occur in
GetIntrinsicIdFromMethod, and in a few places we have 'when' conditions that could just be regular cases. This removes the extra checks so the switch can be simpler and more optimized.In the linker, we also get the IntrinsicId twice, so this adds an optional parameter for a known IntrinsicId.