Skip to content

[release/7.0] Suppress warnings in 6.0 framework (#3000)#3004

Merged
sbomer merged 1 commit intodotnet:release/7.0from
sbomer:backport1
Aug 29, 2022
Merged

[release/7.0] Suppress warnings in 6.0 framework (#3000)#3004
sbomer merged 1 commit intodotnet:release/7.0from
sbomer:backport1

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Aug 25, 2022

Backport of #3000
Fixes #2998

This includes a sidecar XML file which will suppress new warnings in
the 6.0 framework.

Note that a few of the new warnings for compiler-generated code are
suppressed in 7.0 with attributes on local functions. In the XML I had
to suppress them with an attribute on the user method (since the
signature format doesn't support compiler-generated code).

Also note that this approach only includes suppressions for the core
framework, not OOB assemblies. OOB assemblies or third-party nuget
packages will require a slightly different approach to avoid warnings
about unresolved members referenced in XML, in apps where those
assemblies aren't used. There are no warnings that we need to suppress
in OOB assemblies - only new warnings in already trim-incompatible
code.

This also includes a fix for a varargs method issue I found while
running on the 6.0 framework.
@sbomer sbomer requested a review from marek-safar as a code owner August 25, 2022 22:50
@sbomer sbomer requested a review from jeffschwMSFT August 25, 2022 23:18
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@sbomer
Copy link
Member Author

sbomer commented Aug 29, 2022

Ci passed but github didn't get the memo - closing and reopening to see if this helps (I can't merge without green ci).

@sbomer sbomer closed this Aug 29, 2022
@sbomer sbomer reopened this Aug 29, 2022
@sbomer sbomer merged commit aa37c52 into dotnet:release/7.0 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants