Add more tests for parameter dataflow #2918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
approved these changes
Jul 26, 2022
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Add tests for some edge cases due to the analyzer not treating captured parameters as hoisted variables like the linker does. Currently the analyzer doesn't detect hoisted parameters, and it will treat them like normal parameters - warning if a parameter is assigned a value with an annotation that doesn't match the parameter annotation. The linker will treat captured parameters the same as other captured variables, tracking all values that get assigned. So there is a subtle difference in the warning behavior: - Linker won't warn on assignment to annotated captured parameter, but analyzer will. - Linker will produce dataflow warnings for all values assigned to a captured parameter, but analyzer will not. Commit migrated from dotnet/linker@145f0d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for some edge cases due to the analyzer not treating captured parameters as hoisted variables like the linker does. See dotnet/runtime#117171 for a description of the differences.