Avoid dataflow analysis for generic parameters #2908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
approved these changes
Jul 21, 2022
Comment on lines
+31
to
+32
| GetAnnotations (method.DeclaringType).TryGetAnnotation (method, out var methodAnnotations) | ||
| && (methodAnnotations.ReturnParameterAnnotation != DynamicallyAccessedMemberTypes.None || methodAnnotations.ParameterAnnotations != null); |
Member
There was a problem hiding this comment.
This will have to work differently in NativeAOT - where we might have to rely on dataflow to handle generic argument dataflow - it's not clear yet though.
- Stick with Requires*DataFlowAnalysis naming
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
This avoids unnecessarily running the reflection methodbody scanner in the linker, and the dataflow analysis in the analyzer, for methods that were previously only triggering dataflow analysis due to annotated generic parameters. This eliminates unnecessary warnings for reflection access to compiler-generated code. Commit migrated from dotnet/linker@dbb51b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2906
I'll update this to remove
ExpectedWarnings from the tests added in #2907 after that is merged.