Fix syntax node scope and nullable warnings #2900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax node scope should be the innermost node, otherwise GetSymbolInfo will often return null. As an example, GetSymbolInfo will return null for an ArgumentSyntax node, but the underlying expression will likely resolve into a symbol. Also adds proper null checks in case any of the providers return null.
tlakollo
reviewed
Jul 19, 2022
tlakollo
approved these changes
Jul 19, 2022
Contributor
tlakollo
left a comment
tlakollo
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Co-authored-by: Tlakaelel Axayakatl Ceja <[email protected]>
tlakollo
reviewed
Jul 19, 2022
tlakollo
approved these changes
Jul 19, 2022
agocke
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
The syntax node scope should be the innermost node, otherwise GetSymbolInfo will often return null. As an example, GetSymbolInfo will return null for an ArgumentSyntax node, but the underlying expression will likely resolve into a symbol. Also adds proper null checks in case any of the providers return null. Commit migrated from dotnet/linker@7a61266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax node scope should be the innermost node, otherwise
GetSymbolInfo will often return null. As an example, GetSymbolInfo will
return null for an ArgumentSyntax node, but the underlying expression
will likely resolve into a symbol.
Also adds proper null checks in case any of the providers return null.