Map type parameters for static closures #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For a static closure shared by multiple methods - Run existing tests in Release mode too
vitek-karas
approved these changes
Jul 25, 2022
Co-authored-by: Vitek Karas <[email protected]>
- Rename variable
Member
|
Sorry, not sure I'm fully following the change. How does it prevent a sample like https://sharplab.io/#v2:D4AQTAjAsAUCDMACciDCAeAKgPkQb1kSMUOIWQBZEBZACgEp9TiyBWLXAMwkQF5EGfXABMAppwCGAVwA2AF1qZ6AbmYtk7HIk5g+AxrxHjp8xSrUBfWBaA== from producing a lot of warnings or failing? Since there's two constructor calls to a single type. |
agocke
approved these changes
Jul 26, 2022
Member
agocke
left a comment
agocke
left a comment
There was a problem hiding this comment.
Ah, it looks like my case always goes through static fields. LGTM
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
This discovers type parameter mappings between generic type parameters and static closures which reference them. It detects the closure environment by scanning for stsfld instructions which reference generic closure types. There may be multiple methods associated with the same static closure, so this case doesn't produce warnings. This also fixes an unrelated issue where in Release mode, the compiler can generate struct closure environments that will never get instantiated via a ctor call. A new testcase runs the CompilerGeneratedTypes tests in Release mode to cover this. Commit migrated from dotnet/linker@b883ec2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2826
This also fixes an unrelated issue I discovered where in
Releasemode, the compiler can generate struct closure environments that will never get instantiated via a ctor call. I added a testcase that runs the CompilerGeneratedTypes tests in Release mode to cover this.