Fixed AddSuppresionsBeforeAttributeRemoval test #2882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tlakollo
reviewed
Jul 7, 2022
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <linker xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../src/ILLink.Shared/ILLink.LinkAttributes.xsd"> | ||
| <assembly fullname="test, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null"> | ||
| <assembly fullname="*"> |
Contributor
There was a problem hiding this comment.
Feels weird that we have to use star. There is plenty of other XML files for descriptors and XML attributes that use this same method.
Member
There was a problem hiding this comment.
I suggested * as it's robust against changes in the framework. Currently the attribute is in CoreLib, so we could have put CoreLib there instead.
My theory is that this test was added before the attribute was added to the framework, so we declared it in the test itself. Later on once we added the attribute to the framework we removed it from the test, but the XML didn't change. And because the test was already broken (was looking for the wrong warning) it didn't fail.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
The test generated warnings which were not checked. The XML file was pointing to the wrong assembly and the linker raised IL2072 warning. Instead, the test verified the suppression of warning IL2067, which was not raised by the linker in the first place. Co-authored-by: Jeremi Kurdek <[email protected]> Commit migrated from dotnet/linker@2898eba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test generated warnings which were not checked. The XML file was pointing to the wrong assembly and the linker raised IL2072 warning. Instead, the test verified the suppression of warning IL2067, which was not raised by the linker in the first place.
@vitek-karas