Don't let RUC on cctor silence warnings #2705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlakollo
approved these changes
Mar 24, 2022
Contributor
tlakollo
left a comment
tlakollo
left a comment
There was a problem hiding this comment.
Looks good to me, thanks :D
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Don't let RUC on cctor silence warnings Commit migrated from dotnet/linker@7ef273a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't allow RUC on static constructors, and putting one there produces a warning. The current behavior happens to silence warnings from the cctor but it seems more consistent for it not to have any effect on the warnings since it isn't supported.