RAF Attribute unification #2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix new analyzer recommendations about AsSpan and Contains(char) Disable ImplicitNamespaceImports Update Microsoft.NetCore.App.Ref used by analyzer to take new Runtime attribute changes Update analyzer to not use Message as a property in RequiresAssemblyFilesAttribute
Closed
vitek-karas
approved these changes
Jul 22, 2021
Member
|
Looks like we just need the cecil update and then this should be ready. LGTM |
sbomer
approved these changes
Jul 23, 2021
test/ILLink.RoslynAnalyzer.Tests/ILLink.RoslynAnalyzer.Tests.csproj
Outdated
Show resolved
Hide resolved
sbomer
added a commit
to sbomer/linker
that referenced
this pull request
Jul 27, 2021
The submodule update in dotnet#2156 incremented the cecil version, but we were still using 0.11.3 as the version in our package graph. See dotnet#1515 for more context on how this is set up. Fixes dotnet#2173
sbomer
added a commit
that referenced
this pull request
Jul 28, 2021
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Bump sdk version in global.json Fix new analyzer recommendations about AsSpan and Contains(char) Disable ImplicitNamespaceImports Update Microsoft.NetCore.App.Ref used by analyzer to take new Runtime attribute changes Update analyzer to not use Message as a property in RequiresAssemblyFilesAttribute Update cecil to use Microsoft.NETFramework.ReferenceAssemblies.net40 1.0.2 along with taking other cecil updates Commit migrated from dotnet/linker@b888d67
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Bump cecil package version The submodule update in dotnet/linker#2156 incremented the cecil version, but we were still using 0.11.3 as the version in our package graph. See dotnet/linker#1515 for more context on how this is set up. Fixes dotnet/linker#2173 * Remove unnecessary cast Commit migrated from dotnet/linker@0cb9250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump sdk version in global.json
Fix new analyzer recommendations about AsSpan and Contains(char)
Disable ImplicitNamespaceImports
Update Microsoft.NetCore.App.Ref used by analyzer to take new Runtime attribute changes
Update analyzer to not use Message as a property in RequiresAssemblyFilesAttribute