Better tests for various RUC scenarios and fixes#2108
Merged
agocke merged 4 commits intodotnet:mainfrom Jun 29, 2021
Merged
Conversation
Adds several new tests for various RUC scenarios. Cleans up the RUC tests to correctly baseline all warnings it produces. Fixes a product issue with RUC on attribute property setter. Small refactoring in the product.
marek-safar
approved these changes
Jun 24, 2021
… warn Previously we had a select few cases where we did warn. This actually missed quit a few cases. I went through almost all possible values and instead picked those for which we don't want to warn. Added tests for cases where it was possible/practical.
Member
Author
|
I think this is now finally ready for the review. I added a lot more test cases and reworked the implementation. |
agocke
approved these changes
Jun 29, 2021
Member
|
LGTM, merging so we can rebase on top |
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Adds several new tests for various RUC scenarios. Cleans up the RUC tests to correctly baseline all warnings it produces. Fixes a product issue with RUC on attribute property setter. Small refactoring in the product. Commit migrated from dotnet/linker@2f62607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds several new tests for various RUC scenarios.
Cleans up the RUC tests to correctly baseline all warnings it produces.
Fixes a product issue with RUC on attribute property setter.
Small refactoring in the product.