[release/5.0] Build against Cecil submodule #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
changed the title
Member
|
We discussed the ref issue and for 5.0 it should not matter - we're not changing public APIs in Cecil in the fork, so consumers can still refer the official Cecil package and compile against that. At runtime the forked Cecil will be used, but since public APIs are identical everything should work just fine. |
With this change, the nuspec of the ref assembly package will list cecil verision 0.11.2 as a dependency (instead of 5.0.0-rc*). This allows consumers of the ref package to use the publicly released cecil.
Member
Author
|
The ref package will now depend on a package version that matches the official cecil, as discussed with @vitek-karas. |
vitek-karas
approved these changes
Sep 9, 2020
marek-safar
reviewed
Sep 9, 2020
| as the package dependency. This way the linker ref assembly package | ||
| will depend on the publicly available package. Note that we can't set | ||
| just set Version here because Arcade will override it. --> | ||
| <PackageVersion>$(MonoCecilVersion)</PackageVersion> |
Contributor
There was a problem hiding this comment.
It'd be better to stop the build when the versions don't match but it does not look like it's doable with current Cecil setting
marek-safar
approved these changes
Sep 9, 2020
marek-safar
pushed a commit
to marek-safar/linker
that referenced
this pull request
Oct 9, 2020
* Build against Cecil submodule * Depend on official cecil version With this change, the nuspec of the ref assembly package will list cecil verision 0.11.2 as a dependency (instead of 5.0.0-rc*). This allows consumers of the ref package to use the publicly released cecil.
marek-safar
pushed a commit
to marek-safar/linker
that referenced
this pull request
Oct 9, 2020
* Build against Cecil submodule * Depend on official cecil version With this change, the nuspec of the ref assembly package will list cecil verision 0.11.2 as a dependency (instead of 5.0.0-rc*). This allows consumers of the ref package to use the publicly released cecil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this will change a few things:
release/5.0will now have a dependency on the local cecil version (it gets a5.0.0-rc*version from our Versions.props). To consume it, the consuming project needs to include a version of Mono.Cecil compatible with this version, which in practice probably means also building against the submodule and giving it a custom version. @marek-safar I assume that this is OK since we will go back to shipping with the official package when use the ref assembly for plugins in 6. The alternative is to build the ref and lib against different versions of Cecil.