-
Notifications
You must be signed in to change notification settings - Fork 127
Comparing changes
Open a pull request
base repository: dotnet/linker
base: d434293
head repository: dotnet/linker
compare: f09bacf
- 6 commits
- 20 files changed
- 5 contributors
Commits on Jul 25, 2022
-
DynamicallyAccessedMembers CodeFix (#2890)
* Create infrastructure for CodeFixers that will generate attribute flags for DynamicallyAccessedMembers (DAM) trimmer warnings. This commit includes fixers for the warnings `DynamicallyAccessedMembersMismatchParameterTargetsThisParameter` and `DynamicallyAccessedMembersMismatchFieldTargetsThisParameter`. Additional DiagnosticIds will be supported by future commits. * Create new class for the DAM CodeFixer that does not rely on base class. The DAM warnings require different attribute placement depending on the type of warning that is raised, causing it to differ from the implementation of the base class. * Added a test file specifically for the DAM CodeFixer, include tests for the functional fixes as well as tests for fixes that will soon be implemented. * Converted all test cases within DAM to use string literals Co-authored-by: Andy Gocke <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8062da2 - Browse repository at this point
Copy the full SHA 8062da2View commit details -
Update dependencies from https://github.com/dotnet/runtime build 2022…
…0724.4 (#2913) [main] Update dependencies from dotnet/runtime
Configuration menu - View commit details
-
Copy full SHA for 8ffd83c - Browse repository at this point
Copy the full SHA 8ffd83cView commit details
Commits on Jul 26, 2022
-
Map type parameters for static closures (#2899)
This discovers type parameter mappings between generic type parameters and static closures which reference them. It detects the closure environment by scanning for stsfld instructions which reference generic closure types. There may be multiple methods associated with the same static closure, so this case doesn't produce warnings. This also fixes an unrelated issue where in Release mode, the compiler can generate struct closure environments that will never get instantiated via a ctor call. A new testcase runs the CompilerGeneratedTypes tests in Release mode to cover this.
Configuration menu - View commit details
-
Copy full SHA for b883ec2 - Browse repository at this point
Copy the full SHA b883ec2View commit details -
Synchronize file type between analyzer and linker (#2917)
Makes it so user does not have to zip their dumped dependencies file before running the analyzer and updates documentation to reflect the change.
Configuration menu - View commit details
-
Copy full SHA for 907020b - Browse repository at this point
Copy the full SHA 907020bView commit details -
Add more tests for parameter dataflow (#2918)
Add tests for some edge cases due to the analyzer not treating captured parameters as hoisted variables like the linker does. Currently the analyzer doesn't detect hoisted parameters, and it will treat them like normal parameters - warning if a parameter is assigned a value with an annotation that doesn't match the parameter annotation. The linker will treat captured parameters the same as other captured variables, tracking all values that get assigned. So there is a subtle difference in the warning behavior: - Linker won't warn on assignment to annotated captured parameter, but analyzer will. - Linker will produce dataflow warnings for all values assigned to a captured parameter, but analyzer will not.
Configuration menu - View commit details
-
Copy full SHA for 145f0d2 - Browse repository at this point
Copy the full SHA 145f0d2View commit details
Commits on Jul 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f09bacf - Browse repository at this point
Copy the full SHA f09bacfView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d434293...f09bacf