[RISC-V] Build coredistools #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainer because there is no CBL Mariner container for RISC-V. Besides, it's more convenient to work in one docker only.
tomeksowi
force-pushed
the
coredistools
branch
from
dedbd6d to
5b857a3
Compare
sirntar
approved these changes
Jan 19, 2024
Member
Author
|
Close and reopen PR to rerun the CI. |
Member
Author
|
IMO the timeout on dotnet-jitutils-coredistools CI wasn't caused by this change, other open PRs seem to have similar issues. @BruceForstall could you review this please? |
BruceForstall
approved these changes
Jan 23, 2024
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Yes, the timeout in CI is a known problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for R2RDump --disasm
Part of dotnet/runtime#84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar