Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Oct 20, 2022

  • Update TFM netcoreapp3.1 -> net6.0
  • Replace Newtonsoft with STJ.
  • Replace COMPlus_ env vars with DOTNET_
  • Separate out MutateTestRootCommand and update System.CommandLine package (as we have in cg2, r2rdump, etc.).
  • Update docs and package versions.

cc @jakobbotsch, @BruceForstall

<!-- using multiple versions of the runtime with the same managed -->
<!-- executable. -->
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment above still applies, doesn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BruceForstall do you see any issues here? I recall having this discussion about .NET Core 3.1 before, but I don't recall whether this allowed us to use PMI on full framework or what the exact reasoning was.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, netcoreapp3.1 will reach its EOL in about a month (and I think the final servicing has been shipped).

Besides, I doubt we are updating jitutils package to latest releases anymore in dotnet/coreclr repo (where release/3.x code resides).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were targeting 3.1 at the request of @jashook . I think it's reasonable at this point to update to 6.0 (EOL announcement/reminder: https://devblogs.microsoft.com/dotnet/net-core-3-1-will-reach-end-of-support-on-december-13-2022/)

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@BruceForstall BruceForstall merged commit 47d70e1 into dotnet:main Oct 26, 2022
jakobbotsch added a commit to jakobbotsch/jitutils that referenced this pull request Oct 26, 2022
@am11 am11 deleted the feature/update-tfm branch April 14, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants