[Directory.Build.props] Set a dummy PackageVersion to work around VS/NuGet issue #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Apr 18, 2022
| per-TFM, that causes a problem because the package can't have multiple versions in it. | ||
| Set a dummy PackageVersion because we don't actually need it. | ||
| --> | ||
| <PackageVersion>1.0.0.0</PackageVersion> |
Member
There was a problem hiding this comment.
I guess we'd change this if we ever ship a NuGet package from this repo? Maybe wouldn't happen.
Contributor
Author
There was a problem hiding this comment.
I guess we could drop this hack when we no longer target classic.
Contributor
There was a problem hiding this comment.
If (when?) we ever ship a NuGet package from this repo, it should presumably match the version of Java.Interop.dll, which will match the .NET version it's shipping with (6.0.0.0, 7.0.0.0, etc.).
Thus, perhaps we should set $(PackageVersion)=6.0.0.0?
Contributor
Author
There was a problem hiding this comment.
Given that we have no intentions of releasing a NuGet package from this repo, I suspect a 6.0.0.0 version number will be just as obsolete as 1.0.0.0 if we ever do ship a package. 😁
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: NuGet/Home#6461
Trying to build
Java.Interop.csprojin Visual Studio currently fails with several errors like:Even though we don't build NuGet packages, it still attempts to calculate the NuGet package name, which includes the assembly
$(Version)if$(PackageVersion)isn't specified. Because our assemblies have different versions per-TFM, that causes a problem because the package can't have multiple versions in it.We can set a dummy
$(PackageVersion)because we don't actually need it.Also updates the
generator.slnffor additional needed projects to buildgenerator.