[Java.Interop-MonoAndroid.csproj] Set Version after Directory.Build.props #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rops We are setting `<Version>0.1.0.0</Version>` in `Java.Interop-MonoAndroid.csproj`, which is correct. However immediately after that we `<Import Project="..\..\Directory.Build.props" />` which defaults projects to `<Version>$(JIUtilityVersion)</Version>`. This commit reorders the `.csproj` to set the `<Version>` in the project *after* the import.
jonpryor
pushed a commit
that referenced
this pull request
Mar 22, 2022
) Context: https://discord.com/channels/732297728826277939/732297837953679412/955531846865784882 Context: cbd9666 When trying to update some NuGet packages which were using Visual Studio 17.3 / Xamarin.Android 12.3.0 preview bits, we encountered an "oddity": the generated assembly was referencing Java.Interop.dll, Version=0.2.0.6 (?!). This was unexpected, as we wanted Java.Interop.dll to have Version=0.1.0.0; see also 2d5431f. We are setting `$(Version)`=0.1.0.0 in `Java.Interop-MonoAndroid.csproj`, which is what we intended. However, immediately after setting `$(Version)` we do: <Import Project="..\..\Directory.Build.props" /> which *overrides* `$(Version)`, setting it to `$(JIUtilityVersion)`; see commit cbd9666. This was *unintended*. Update `Java.Interop-MonoAndroid.csproj` so that `$(Version)` is set *after* `<Import/>`ing `Directory.Build.props`, so that the `$(Version)` override is actually *used*. This should cause Java.Interop.dll within Xamarin.Android to have Version=0.1.0.0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are setting
<Version>0.1.0.0</Version>inJava.Interop-MonoAndroid.csproj, which is correct. However immediately after that we<Import Project="..\..\Directory.Build.props" />which defaults projects to<Version>$(JIUtilityVersion)</Version>.This commit reorders the
.csprojto set the<Version>in the project after the import.