Skip to content

[global.json] Update Microsoft.Build.NoTargets to 2.0.1. #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonpryor merged 1 commit into from
Jan 11, 2021
Merged

[global.json] Update Microsoft.Build.NoTargets to 2.0.1. #775

jonpryor merged 1 commit into from
Jan 11, 2021

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Jan 8, 2021 •
edited
Loading

Java.Interop is using Microsoft.Build.NoTargets version 1.0.110, while Xamarin.Android uses 2.0.1. This causes some build warnings when building XA:

/Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/tools/java-source-utils/java-source-utils.csproj :
warning MSB4240: Multiple versions of the same SDK "Microsoft.Build.NoTargets" cannot be specified. 
The previously resolved SDK version "2.0.1" from location "/Users/builder/azdo/_work/1/s/xamarin-android/src/
java-runtime/java-runtime.csproj" will be used and the version "1.0.110" will be ignored.

Fix this by moving the version number from the individual csproj's and into a global.json with a version matching XA's global.json.

@jpobst jpobst marked this pull request as ready for review January 8, 2021 15:44
@jpobst jpobst requested a review from jonpryor January 8, 2021 15:44
@jonpryor jonpryor merged commit d1b872a into master Jan 11, 2021
@jonpryor jonpryor deleted the notargets-version branch January 11, 2021 20:23
@jpobst jpobst added this to the 11.2 (16.10 / 8.10) milestone Feb 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

11.3 (16.10 / 8.10)

Development

Successfully merging this pull request may close these issues.

3 participants

@jpobst @jonpryor