Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Feb 19, 2020

Fixes #572.

Do not generate bindings for package-private nested types to match logic for top level classes.

@jpobst jpobst marked this pull request as ready for review February 19, 2020 23:01
@jpobst jpobst requested a review from jonpryor February 19, 2020 23:01
@jonpryor jonpryor merged commit fa10e98 into master Feb 20, 2020
@jonpryor jonpryor deleted the package-private branch February 20, 2020 16:24
jonpryor pushed a commit that referenced this pull request Feb 24, 2020
Fixes: #572

Do not bind ["package private"][0] nested types   For example, given:

	public class OuterExample {
	    /* package */ static class InnerExample {
	    }
	}

The type `OuterExample.InnerExample` *should not be bound*.

Previously `OuterExample.InnerExample` *would* be bound as a
*`public`* type (?!), which could result in later Java Callable Wrapper
compilation errors, if/when they attempted to access the
package-private types

This change causes package-private nested types to behave the same as
top-level package-private types, which were never bound.

[0]: https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested Package-Private types should not be bound

3 participants