Must we use a temporary file? As opposed to copying into a MemoryStream?

The largest annotations.xml I see within platform-tools_r28.0.1-darwin.zip is 76017 bytes for android/renderscript/annotations.xml, which isn't that large, and the 76KB should be quickly collectable once it's copied into the (much larger!) XDocument.

We should probably mention https://issuetracker.google.com/issues/116182838, either here, in the commit message, or both. (I like "both". :-)

I would think using blocks, you could avoid the need for this method entirely. The empty try-catch is the part we shouldn't really need.

Was there some trouble with a Stream getting double-disposed? It might be there is just a place you need to use an overload of leaveOpen: true.

The streams in question aren't placed in using blocks because I don't want to nest the blocks too much and the streams may be null. The method provides for cleaner code and the empty catch is to discard any and all errors in a place where we really don't care about any errors.

I don't see how the streams would be null if using was used?

It seems cleaner to me to just do something like:

	static XDocument SafeXmlLoad (Stream s, string fileName)
	{
		// We must save to a temporary stream because the stream doesn't support seeking and should the
		// parsing fail we won't be able to go back to its beginnig to reparse it.
		using (var ms = new MemoryStream ()) {
			s.CopyTo (ms);
			ms.Seek (0, SeekOrigin.Begin);

			try {
				return XDocument.Load (ms);
			} catch (XmlException ex) {
				Console.Error.WriteLine ($"Warning: failed to load annotation document '{fileName}' directly from the annotations archive. {ex.Message}");
				Console.Error.WriteLine ("Attempting to fix up and reload");
			}

			try {
				using (var ns = FixAnnotationXML (ms))
					return XDocument.Load (ns);
			} catch (Exception ex) {
				throw new InvalidOperationException ($"Failed to fix up invalid XML in annotation document '{fileName}'. {ex.Message}", ex);
			}
		}
	}