method parameter type may contain "params " and cannot be used by fields. #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Jan 26, 2018
tools/generator/CodeGenerator.cs
Outdated
| return "void"; | ||
| if (s.StartsWith ("params ")) | ||
| return "params " + GetOutputName (s.Substring (6)); | ||
| return "params " + GetOutputName (s.Substring (7)); |
Contributor
There was a problem hiding this comment.
Where is 7 coming from? Presumably it's "params ".Length.
Assuming that 7 is coming from a string length, could you lease replace 7 with e.g. "params ".Length, so that the source value is obvious?
jonpryor
reviewed
Jan 26, 2018
tools/generator/InterfaceGen.cs
Outdated
| continue; | ||
| sw.WriteLine (); | ||
| sw.WriteLine ("{0}\t{1} {2};", indent, opt.GetOutputName (p.Type), opt.GetSafeIdentifier (p.Name)); | ||
| var safeTypeName = p.Type.StartsWith ("params ", StringComparison.Ordinal) ? p.Type.Substring (7) : p.Type; |
Contributor
There was a problem hiding this comment.
This usage makes the 7 a bit more obvious, as "params " is on the same line/nearby (unlike the previous spot), but I would still prefer use of "params ".Length over a hardcoded 7.
Contributor
Author
|
If you think your suggested changes are REALLY important, then make another PR to achieve them. |
jonpryor
reviewed
Jan 26, 2018
| string args_name = GetArgsName (m); | ||
| if (m.RetVal.IsVoid || m.IsEventHandlerWithHandledProperty) { | ||
| if (!m.IsSimpleEventHandler || m.IsEventHandlerWithHandledProperty) { | ||
| sw.WriteLine ("{0}// event args for {1}.{2}", indent, this.JavaName, m.JavaName); |
Contributor
There was a problem hiding this comment.
This line is causing the unit tests to fail, as the expected file contents don't contain it.
…lds. This fixes dotnet/android#1138 It is quite corner case, where ... arguments are used in interfaces that can be converted to events. Parameter types cannot be simply used for fields and parameters because they cannot take "params" as their modifiers. The real code fix should be in Parameter.cs, but that would require a lot of changes unlike this tiny fix.
atsushieno
force-pushed
the
fix-xa-1138
branch
from
425738f to
7ff8d10
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes dotnet/android#1138
It is quite corner case, where ... arguments are used in interfaces that
can be converted to events.
Parameter types cannot be simply used for fields and parameters because
they cannot take "params" as their modifiers.
The real code fix should be in Parameter.cs, but that would require
a lot of changes unlike this tiny fix.