Skip to content

Conversation

@atsushieno
Copy link
Contributor

No description provided.

@jonpryor
Copy link
Contributor

I don't understand what this patch is attempting to fix, or how it does so. Best I can tell, it will do nothing.

After line 329, rawXML contains the first 500 characters in path, or the entire contents of the file, whichever is smaller.

The only thing the .Trim() will do is remove leading and trailing whitespace for the subsequent <api>/<package check (line 331) or package/; check (lines 333-334).

I fail to see how the .Trim() will change the behavior.

@jonpryor jonpryor merged commit c5e04d1 into dotnet:master Nov 14, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants