[class-parse][api-xml-adjuster] add "platform" number on <api> element. #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet/android#824 added some code to api-merge to handle "platform" attributes on <api> element, but those attributes on api-*.xml.in were not automatically generated. That means, every time we regenerate api-*.xml.in from api-xml-adjuster, those files are invalid and causes build breakages. Add more code in class-parse and api-xml-adjuster so that they can be automatically added, depending on the command line.
grendello
approved these changes
Oct 25, 2017
Redth
pushed a commit
to Redth/java.interop
that referenced
this pull request
Oct 26, 2017
…t. (dotnet#197) dotnet/android#824 added some code to api-merge to handle "platform" attributes on <api> element, but those attributes on api-*.xml.in were not automatically generated. That means, every time we regenerate api-*.xml.in from api-xml-adjuster, those files are invalid and causes build breakages. Add more code in class-parse and api-xml-adjuster so that they can be automatically added, depending on the command line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/android#824 added some code to
api-merge to handle "platform" attributes on element, but those
attributes on api-*.xml.in were not automatically generated. That means,
every time we regenerate api-*.xml.in from api-xml-adjuster, those files
are invalid and causes build breakages.
Add more code in class-parse and api-xml-adjuster so that they can be
automatically added, depending on the command line.