[Java.Interop.GenericMarshaler] fix trimmer warnings #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#9846 When trying to build `Mono.Android-Tests` for NativeAOT, I get many warnings like this (that are upgraded to errors): src\Java.Interop.GenericMarshaler\Java.Interop.GenericMarshaler\JniPeerInstanceMethodsExtensions.cs(10874,17): error IL2091: 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors', 'DynamicallyAccessedMemberTypes.NonPublicConstructors' in 'Java.Interop.JniRuntime.JniValueManager.GetValueMarshaler<T>()'. The generic parameter 'T16' of 'Java.Interop.GenericMarshaler.JniPeerInstanceMethodsExtensions.InvokeGenericVirtualObjectMethod<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16>(JniInstanceMethods, String, IJavaPeerable, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. Build failed with 2992 error(s) in 4.8s To solve this here, we can import: <Import Project="..\..\build-tools\trim-analyzers\trim-analyzers.props" /> To see all the warnings *here*, and then I added the missing attributes to solve the warnings.
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Feb 26, 2025
Changes: dotnet/java-interop@471afd4...719e615 * dotnet/java-interop@719e6159: [Hello-Java.Base] Add support for Java Callable Wrappers (dotnet/java-interop#1315) * dotnet/java-interop@1e7f269b: [Java.Interop.GenericMarshaler] fix trimmer warnings (dotnet/java-interop#1314)
jonathanpeppers
pushed a commit
to dotnet/android
that referenced
this pull request
Feb 27, 2025
Changes: dotnet/java-interop@471afd4...719e615 * dotnet/java-interop@719e6159: [Hello-Java.Base] Add support for Java Callable Wrappers (dotnet/java-interop#1315) * dotnet/java-interop@1e7f269b: [Java.Interop.GenericMarshaler] fix trimmer warnings (dotnet/java-interop#1314)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#9846
When trying to build
Mono.Android-Testsfor NativeAOT, I get many warnings like this (that are upgraded to errors):To solve this here, we can import:
To see all the warnings here, and then I added the missing attributes to solve the warnings.