Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/java-interop
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 19be370
Choose a base ref
...
head repository: dotnet/java-interop
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ef82a07
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Sep 23, 2025

  1. [generator] FixupMethodOverrides() checks properties (#1366) 

    Context: #1313
Fixes: dotnet/android#10509

In .NET 10 RC 1, `View.Foreground` is defined in C# as:

    [SupportedOSPlatform("android23.0")]
    public virtual Drawable? Foreground { get; set; }

But `FrameLayout.Foreground` is defined as:

    [UnsupportedOSPlatform("android23.0")]
    public override Drawable? Foreground { get; set; }

I think this is the exact same bug that was addressed in #1313 for
methods, but we still have the issue for properties. I was able to
duplicate the test and make a `getThing()` and `setThing()` methods in
Java to see the issue.

I updated the `FixupMethodOverrides()` to iterate over properties
and do the same fixup for property getters and setters.

This also needed to be done for:

* Interfaces
* Fields (think of `static final int` values)
    @jonathanpeppers
    jonathanpeppers authored Sep 23, 2025
    Configuration menu
    Copy the full SHA
    ef82a07 View commit details
    Browse the repository at this point in the history
Loading