[Java.Interop-MonoAndroid] Set Version after Directory.Build.props (#965)

jpobst · web-flow · commit ed9c2abfd9db · 2022-03-22T15:50:01.000-04:00
Context: https://discord.com/channels/732297728826277939/732297837953679412/955531846865784882 Context: cbd9666 When trying to update some NuGet packages which were using Visual Studio 17.3 / Xamarin.Android 12.3.0 preview bits, we encountered an "oddity": the generated assembly was referencing Java.Interop.dll, Version=0.2.0.6 (?!). This was unexpected, as we wanted Java.Interop.dll to have Version=0.1.0.0; see also 2d5431f. We are setting `$(Version)`=0.1.0.0 in `Java.Interop-MonoAndroid.csproj`, which is what we intended. However, immediately after setting `$(Version)` we do: <Import Project="..\..\Directory.Build.props" /> which *overrides* `$(Version)`, setting it to `$(JIUtilityVersion)`; see commit cbd9666. This was *unintended*. Update `Java.Interop-MonoAndroid.csproj` so that `$(Version)` is set *after* `<Import/>`ing `Directory.Build.props`, so that the `$(Version)` override is actually *used*. This should cause Java.Interop.dll within Xamarin.Android to have Version=0.1.0.0.
diff --git a/src/Java.Interop/Java.Interop-MonoAndroid.csproj b/src/Java.Interop/Java.Interop-MonoAndroid.csproj
@@ -17,10 +17,10 @@
     <LangVersion>8.0</LangVersion>
     <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
     <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
-    <Version>0.1.0.0</Version>
   </PropertyGroup>
   <Import Project="..\..\Directory.Build.props" />
   <PropertyGroup>
+    <Version>0.1.0.0</Version>
     <XAConfigPath>..\..\bin\Build$(Configuration)\XAConfig.props</XAConfigPath>
   </PropertyGroup>
   <Import Condition="Exists ('$(XAConfigPath)')" Project="$(XAConfigPath)" />
@@ -114,4 +114,4 @@
     <None Include="Documentation\Java.Interop\JniManagedPeerStates.xml" />
     <None Include="Documentation\Java.Interop\JniEnvironment.References.xml" />
   </ItemGroup>
-</Project>
+</Project>
