Run tests by default and again enable them in UB#19366
Conversation
With be917a9, the unified build tests were moved out of the VMR build stage into the test stage. As none of the vertical builds specified runTests: true, the tests stopped running. Change the runTests default to true as every single job should run tests.
|
New mac failure: For Docker, we override the working directory to the root of the repo with the |
Yes. We specify |
|
Wow @directhex you are a life saver. Thanks for debugging this. The fix was simple :) |
|
|
||
| # Only use Docker when a container is specified | ||
| if [[ -n "${{ parameters.container }}" ]]; then | ||
| docker run --rm $dockerVolumeArgs -w /vmr ${{ parameters.container }} ./build.sh /bl:artifacts/log/Release/Test.binlog --test $sourceOnlyArgs $extraBuildProperties $(additionalBuildArgs) |
There was a problem hiding this comment.
Consider encapsulating the build command to avoid duplication between container and non-container execution..
The benefit is to ensure equality between the two and improve the maintainability of the code.
There was a problem hiding this comment.
Yes, we discussed this in one of the above resolved conversations. We want to get rid of all this and just use YML variables to construct the build commands, outside of script steps. I just filed https://github.com/dotnet/source-build/issues/4307 to track this.
|
Failure on Windows. Do we want to just disable tests on Windows & bring that up in a follow-up? |
After #19366 the `runTests` variable is true on Windows too so the step to copy the nuget.config for source-build smoke tests started running there, resulting in an error: > 'cp' is not recognized as an internal or external command, operable program or batch file. Skip that step when we're not in doing a source-build.
This step is no longer needed after #19366.
4 participants
With be917a9, the unified build tests were moved out of the
VMR build stage into the test stage. As none
of the vertical builds specified runTests: true,
the tests stopped running.
Change the runTests default to true as every single job should run tests.