Merged
Conversation
Closes: dotnet/source-build#3843 Closes: dotnet/source-build#3844 Closes: dotnet/source-build#3846 Closes: dotnet/source-build#3848
ViktorHofer
reviewed
Apr 5, 2024
added 2 commits
April 5, 2024 21:37
Member
Member
|
Please wait until #19366 is merged and the merge with latest main to make sure that the tests work with these added lanes. |
3 tasks
Author
|
/azp run installer-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
windowsdesktop failure is unrelated. |
ViktorHofer
approved these changes
Apr 10, 2024
ViktorHofer
reviewed
Apr 10, 2024
| useMonoRuntime: true | ||
| targetOS: linux-musl | ||
| targetArchitecture: x64 | ||
| extraProperties: /p:TargetRID=linux-musl-x64 |
Member
There was a problem hiding this comment.
I just noticed that the TargetRID isn't calculated based on TargetOS and TargetArchitecture which seems weird to me but is entirely unrelated to this change.
|
Happy to see this! I've divested from developping the Alpine dotnet package further due to lack of time, but hopefully this will help get better support for mono which is what cripples mono-based runtimes on musl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: dotnet/source-build#3843
Closes: dotnet/source-build#3844
Closes: dotnet/source-build#3846
Closes: dotnet/source-build#3848