Skip to content

Fix #18777#18778

Merged
directhex merged 5 commits intodotnet:mainfrom
directhex:fix-usemonoruntime
Feb 26, 2024
Merged

Fix #18777#18778
directhex merged 5 commits intodotnet:mainfrom
directhex:fix-usemonoruntime

Conversation

@directhex
Copy link

@tmds pointed out the mistakes in the last PR.

@directhex directhex requested a review from a team as a code owner February 26, 2024 17:29
@ViktorHofer
Copy link
Member

The switch is currently only exposed in build.sh and grouped under "source-build" settings: https://github.com/dotnet/dotnet/blob/e38ba1f611371c227894b0aaa4fa8ddfb0aaf8d7/build.sh#L31

If this affects more than just source-build, please move the switch into another section. Should this also be exposed on build.ps1?

@directhex
Copy link
Author

If this affects more than just source-build, please move the switch into another section. Should this also be exposed on build.ps1?

Good question. I don't think we use optional Mono runtime flavour for any runtime builds today, but I think we might for a perf job?

https://github.com/dotnet/runtime/blob/main/eng/pipelines/coreclr/templates/perf-job.yml#L99

So a fair while down the road it might be needed

@ViktorHofer
Copy link
Member

One more place to move:

- name: useMonoRuntime
displayName: True when build output uses the mono runtime
type: boolean
default: false

@directhex directhex enabled auto-merge (squash) February 26, 2024 18:07
@directhex directhex merged commit 7f74937 into dotnet:main Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants