Conversation
This reverts commit 243880c.
| customEnvVars="$customEnvVars ROOTFS_DIR=${{ parameters.crossRootFs}}" | ||
| if [[ '${{ parameters.targetArchitecture }}' != 'wasm' ]]; then | ||
| customEnvVars="$customEnvVars CROSSCOMPILE=1" | ||
| fi |
There was a problem hiding this comment.
which issues does setting CROSSCOMPILE cause on wasm?
There was a problem hiding this comment.
There's some logic in gen-buildsys i think which sees CROSSCOMPILE=1 and does a build for $BuildOS-$TargetArch instead of $TargetOS-$TargetArch, something like that, anyway it fails on "linux-wasm isn't a thing"
There was a problem hiding this comment.
ok, would you mind filing an issue for this? I'd rather fix this in runtime than hardcoding this logic in the VMR (it's fine for now).
| - name: androidCrossContainer | ||
| value: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-cross-android-amd64 | ||
| - name: wasmCrossContainer | ||
| value: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-webassembly-20230917141449-2aaa02c |
There was a problem hiding this comment.
I know we pinned this version because of some issue in runtime but we should get back to the floating tag ASAP, do you know if we have an issue?
There was a problem hiding this comment.
I don't know, I just pulled what was in my runtime checkout. I'll ask someone from the wasm team tomorrow
There was a problem hiding this comment.
dotnet/runtime#92243 was the last time it was touched. IIRC there was some issue with mariner and the libc for one of the wasm deps??
3 participants
Closes: dotnet/source-build#3835
Closes: dotnet/source-build#3886